[llvm] [Workflows] Enable commit access requests via GitHub issues (PR #100458)

[Tom Stellard via llvm-commits]

https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/100458

>From 60ef4ac509016449dd9afb37c8cebfa82b94eab2 Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Tue, 16 Jul 2024 19:50:51 +0000
Subject: [PATCH 1/5] [Workflows] Enable commit access requests via GitHub
 issues

This updates the auto-labeler to match a specific issue title that
is going to be used for requesting commit access and then add the
infrastructure:commit-access-request label.

This will notify the admin team who will be able to handle the request.

See https://discourse.llvm.org/t/rfc-change-the-process-for-requesting-commit-access/80184
---
 .github/new-issues-labeler.yml |  3 +++
 llvm/docs/DeveloperPolicy.rst  | 11 ++++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/.github/new-issues-labeler.yml b/.github/new-issues-labeler.yml
index a5933d7fc9b372..028b7fbd5bdda1 100644
--- a/.github/new-issues-labeler.yml
+++ b/.github/new-issues-labeler.yml
@@ -27,3 +27,6 @@
 
 'bolt':
   - '/\bbolt(?!\-)\b/i'
+
+'infrastructure:commit-access-request':
+  - '/Request Commit Access/'
diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index f2ac46e6c04f23..95dd7251b4a138 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -476,11 +476,12 @@ Obtaining Commit Access
 -----------------------
 
 We grant commit access to contributors with a track record of submitting high
-quality patches.  If you would like commit access, please send an email to
-`Chris <mailto:clattner at llvm.org>`_ with your GitHub username.  This is true
-for former contributors with SVN access as well as new contributors. If
-approved, a GitHub invitation will be sent to your GitHub account. In case you
-don't get notification from GitHub, go to
+quality patches.  If you would like commit access, please use this `link
+<https://github.com/llvm/llvm-project/issues/new?title=Request%20Commit%20Access%20For%20<user>&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file
+and issue and request commit access.  Replace the <user> string in the title
+with your github username, and explain why you are requesting commit access in
+the issue description.  If approved, a GitHub invitation will be sent to your
+GitHub account. In case you don't get notification from GitHub, go to
 `Invitation Link <https://github.com/orgs/llvm/invitation>`_ directly. Once
 accept the invitation, you'll get commit access.
 

>From beda0a35441f5a21c6f55499b708db7377e2623d Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Mon, 29 Jul 2024 14:46:49 -0700
Subject: [PATCH 2/5] Address Review Comments:

* Shorten label name
* Fix typos
---
 .github/new-issues-labeler.yml | 2 +-
 llvm/docs/DeveloperPolicy.rst  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/new-issues-labeler.yml b/.github/new-issues-labeler.yml
index 028b7fbd5bdda1..860535bbe30835 100644
--- a/.github/new-issues-labeler.yml
+++ b/.github/new-issues-labeler.yml
@@ -28,5 +28,5 @@
 'bolt':
   - '/\bbolt(?!\-)\b/i'
 
-'infrastructure:commit-access-request':
+'infra:commit-access-request':
   - '/Request Commit Access/'
diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index 95dd7251b4a138..ac82a75d89474d 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -478,12 +478,12 @@ Obtaining Commit Access
 We grant commit access to contributors with a track record of submitting high
 quality patches.  If you would like commit access, please use this `link
 <https://github.com/llvm/llvm-project/issues/new?title=Request%20Commit%20Access%20For%20<user>&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file
-and issue and request commit access.  Replace the <user> string in the title
+an issue and request commit access.  Replace the <user> string in the title
 with your github username, and explain why you are requesting commit access in
 the issue description.  If approved, a GitHub invitation will be sent to your
 GitHub account. In case you don't get notification from GitHub, go to
 `Invitation Link <https://github.com/orgs/llvm/invitation>`_ directly. Once
-accept the invitation, you'll get commit access.
+you accept the invitation, you'll get commit access.
 
 Prior to obtaining commit access, it is common practice to request that
 someone with commit access commits on your behalf. When doing so, please

>From 326ce28dee3de54a661f3f551bb8f16af7067161 Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Tue, 3 Sep 2024 15:46:03 -0700
Subject: [PATCH 3/5] Fix documentation build

---
 llvm/docs/DeveloperPolicy.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index 45aca29373f3ac..64fe790cd0ae09 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -476,8 +476,7 @@ Obtaining Commit Access
 -----------------------
 
 We grant commit access to contributors that can provide a valid justification.
-If you would like commit access, please use this `link
-<https://github.com/llvm/llvm-project/issues/new?title=Request%20Commit%20Access%20For%20<user>&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file
+If you would like commit access, please use this `link <https://github.com/llvm/llvm-project/issues/new?title=Request%20Commit%20Access%20For%20<user>&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file
 an issue and request commit access.  Replace the <user> string in the title
 with your github username, and explain why you are requesting commit access in
 the issue description.  If approved, a GitHub invitation will be sent to your

>From 11801206cda5bdbadfce7ee4712285844708af8e Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Tue, 3 Sep 2024 15:53:28 -0700
Subject: [PATCH 4/5] Fix documentation again

---
 llvm/docs/DeveloperPolicy.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index 64fe790cd0ae09..c0095b1594021c 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -476,7 +476,7 @@ Obtaining Commit Access
 -----------------------
 
 We grant commit access to contributors that can provide a valid justification.
-If you would like commit access, please use this `link <https://github.com/llvm/llvm-project/issues/new?title=Request%20Commit%20Access%20For%20<user>&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file
+If you would like commit access, please use this `link <https://github.com/llvm/llvm-project/issues/new?title=Request%20Commit%20Access%20For%20%3Cuser%3E&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file
 an issue and request commit access.  Replace the <user> string in the title
 with your github username, and explain why you are requesting commit access in
 the issue description.  If approved, a GitHub invitation will be sent to your

>From e4b65120ef6fae52610a5a731b466d7828bbf6a0 Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Mon, 11 Nov 2024 11:10:25 -0800
Subject: [PATCH 5/5] Update llvm/docs/DeveloperPolicy.rst

Co-authored-by: Vlad Serebrennikov <serebrennikov.vladislav at gmail.com>
---
 llvm/docs/DeveloperPolicy.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index c0095b1594021c..d1e72996d959aa 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -479,7 +479,7 @@ We grant commit access to contributors that can provide a valid justification.
 If you would like commit access, please use this `link <https://github.com/llvm/llvm-project/issues/new?title=Request%20Commit%20Access%20For%20%3Cuser%3E&body=%23%23%23%20Why%20Are%20you%20requesting%20commit%20access%20?>`_ to file
 an issue and request commit access.  Replace the <user> string in the title
 with your github username, and explain why you are requesting commit access in
-the issue description.  If approved, a GitHub invitation will be sent to your
+the issue description. If approved, a GitHub invitation will be sent to your
 GitHub account. In case you don't get notification from GitHub, go to
 `Invitation Link <https://github.com/orgs/llvm/invitation>`_ directly. Once
 you accept the invitation, you'll get commit access.