[llvm] [RISCV][GISel] Use boolean predicated legalization action methods to remove a custom lambda. (PR #115628)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 11 08:47:49 PST 2024


topperc wrote:

> Following up, do we think we need several versions of `llvm/test/CodeGen/RISCV/GlobalISel/legalizer-info-validation.mir` which take the predicates into account - presumably coverage is now different depending on the subtarget used. I don't know how much this coverage would help or not, it's unclear if that testcase is for RISC-V, or for GlobalISel - if there's a regression, which is more likely to be the problem?

If there's a regression the problem is most likely RISC-V.

The test is currently using a superset of most of the predicates. The best test would have one for each predicate, but that's going to get expensive. I'll think more about it.

https://github.com/llvm/llvm-project/pull/115628


More information about the llvm-commits mailing list