[llvm] [AMDGPU][Attributor] Make `AAAMDFlatWorkGroupSize` honor existing attribute (PR #114357)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 12:49:29 PDT 2024


================
@@ -144,6 +144,20 @@ static bool funcRequiresHostcallPtr(const Function &F) {
 }
 
 namespace {
+
+std::optional<std::pair<unsigned, unsigned>> static parseRangeAttribute(
----------------
arsenm wrote:

Can you add an overload of getIntegerPairAttribute that takes the raw Attribute instead of duplicating the parsing? This also omits the context errors (I guess it's also bad that we'll spam them everywhere. We should probably make this an IR verifier check) 

https://github.com/llvm/llvm-project/pull/114357


More information about the llvm-commits mailing list