[llvm] [LLVM][AsmParser] Add support for C style comments (PR #111554)

Rahul Joshi via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 12:00:53 PDT 2024


jurahul wrote:

Yes, it is adopted from TGLexer. There is no good reason to support nested
comments though.

On Thu, Oct 31, 2024 at 11:58 AM Jessica Clarke ***@***.***>
wrote:

> ***@***.**** commented on this pull request.
> ------------------------------
>
> In llvm/lib/AsmParser/LLLexer.cpp
> <https://github.com/llvm/llvm-project/pull/111554#discussion_r1825033614>:
>
> > @@ -262,6 +274,38 @@ void LLLexer::SkipLineComment() {
>    }
>  }
>
> +/// SkipCComment - This skips C-style /**/ comments.  The only difference from C
> +/// is that we allow nesting.
>
> Interesting. Dates back to af282ae
> <https://github.com/llvm/llvm-project/commit/af282ae26e784d42b15ae3aff887f4f3769eddec>,
> July 2003.
>
>> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/111554#discussion_r1825033614>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APRMUB44Q4KMZTZ2BHVAJE3Z6J4TRAVCNFSM6AAAAABPSVE2GCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBYHA3DIOJXG4>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/111554


More information about the llvm-commits mailing list