[llvm] Fix failing test gcov_ctr_ref_init.ll (PR #114428)

Zaara Syeda via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 31 09:58:04 PDT 2024


https://github.com/syzaara updated https://github.com/llvm/llvm-project/pull/114428

>From 1e32631b50ea414ad8ecf0c2f5d268ffecc13d8c Mon Sep 17 00:00:00 2001
From: Zaara Syeda <syzaara at ca.ibm.com>
Date: Thu, 31 Oct 2024 12:45:49 -0400
Subject: [PATCH 1/2] Fix failing test gcov_ctr_ref_init.ll

Test failing after merge of PR:
Enable aggressive constant merge in GlobalMerge for AIX
---
 llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll b/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll
index 4710d5c14e5b19..1e819652fad473 100644
--- a/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll
+++ b/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll
@@ -20,11 +20,12 @@ target triple = "powerpc-ibm-aix"
 ; CHECK-NEXT: __llvm_gcov_ctr:
 ; CHECK-NEXT:     .space  16
 ; CHECK-NEXT: __llvm_gcov_ctr.1:
-; CHECK-NEXT:     .extern .llvm_gcda_start_file[PR]
+; CHECK:          .extern .llvm_gcda_start_file[PR]
 ; CHECK-NEXT:     .extern .llvm_gcda_emit_function[PR]
 ; CHECK-NEXT:     .extern .llvm_gcda_emit_arcs[PR]
 ; CHECK-NEXT:     .extern .llvm_gcda_summary_info[PR]
 ; CHECK-NEXT:     .extern .llvm_gcda_end_file[PR]
+; CHECK-NEXT:     .csect __llvm_gcov_ctr_section[RW],3
 ; CHECK-RW-NEXT:    .ref __llvm_covinit[RW]
 ; CHECK-RO-NEXT:    .ref __llvm_covinit[RO]
 

>From 3a8e721e44ba34223de56d74b208cfb7e6f621ca Mon Sep 17 00:00:00 2001
From: Zaara Syeda <syzaara at ca.ibm.com>
Date: Thu, 31 Oct 2024 12:57:35 -0400
Subject: [PATCH 2/2] Fix test

---
 llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll b/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll
index 1e819652fad473..4969aec0a14942 100644
--- a/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll
+++ b/llvm/test/CodeGen/PowerPC/gcov_ctr_ref_init.ll
@@ -12,20 +12,11 @@ target triple = "powerpc-ibm-aix"
 ; CHECK-NEXT: L..__llvm_covinit_functions:
 ; CHECK-NEXT:     .vbyte  4, __llvm_gcov_writeout[DS]
 ; CHECK-NEXT:     .vbyte  4, __llvm_gcov_reset[DS]
+; The first .csect directive below is specifying the content of the csect.
+; The second .csect directive below is used to insert the .ref pseudo
+; instruction.
+; CHECK:    .csect __llvm_gcov_ctr_section[RW],3
 ; CHECK:    .csect __llvm_gcov_ctr_section[RW],3
-; CHECK-NEXT:    .lglobl __llvm_gcov_ctr                 # @_MergedGlobals
-; CHECK-NEXT:    .lglobl __llvm_gcov_ctr.1
-; CHECK-NEXT:    .align  3
-; CHECK-NEXT: L.._MergedGlobals:
-; CHECK-NEXT: __llvm_gcov_ctr:
-; CHECK-NEXT:     .space  16
-; CHECK-NEXT: __llvm_gcov_ctr.1:
-; CHECK:          .extern .llvm_gcda_start_file[PR]
-; CHECK-NEXT:     .extern .llvm_gcda_emit_function[PR]
-; CHECK-NEXT:     .extern .llvm_gcda_emit_arcs[PR]
-; CHECK-NEXT:     .extern .llvm_gcda_summary_info[PR]
-; CHECK-NEXT:     .extern .llvm_gcda_end_file[PR]
-; CHECK-NEXT:     .csect __llvm_gcov_ctr_section[RW],3
 ; CHECK-RW-NEXT:    .ref __llvm_covinit[RW]
 ; CHECK-RO-NEXT:    .ref __llvm_covinit[RO]
 



More information about the llvm-commits mailing list