[compiler-rt] [win/asan] Search both higher and lower in AllocateTrampolineRegion (PR #114212)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 31 05:12:12 PDT 2024
================
@@ -340,32 +347,66 @@ struct TrampolineMemoryRegion {
uptr max_size;
};
-UNUSED static const uptr kTrampolineScanLimitRange = 1ull << 31; // 2 gig
+UNUSED static const uptr kTrampolineRangeLimit = 1ull << 31; // 2 gig
static const int kMaxTrampolineRegion = 1024;
static TrampolineMemoryRegion TrampolineRegions[kMaxTrampolineRegion];
-static void *AllocateTrampolineRegion(uptr image_address, size_t granularity) {
-#if SANITIZER_WINDOWS64
- uptr address = image_address;
- uptr scanned = 0;
- while (scanned < kTrampolineScanLimitRange) {
+static void *AllocateTrampolineRegion(uptr min_addr, uptr max_addr,
----------------
zmodem wrote:
Added a comment that should make it more clear.
It doesn't go as far as providing a concrete example like you suggested, because the order would depend on the addresses, and at that point I think the example would be more complex than it's worth.
https://github.com/llvm/llvm-project/pull/114212
More information about the llvm-commits
mailing list