[llvm] 847f4ef - [X86] Use getAllOnesConstant instead of getConstant(-1). NFC (#114299)

via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 16:22:27 PDT 2024


Author: Craig Topper
Date: 2024-10-30T16:22:23-07:00
New Revision: 847f4ef21b4a953bb6dd6477791e8d95b6db2509

URL: https://github.com/llvm/llvm-project/commit/847f4ef21b4a953bb6dd6477791e8d95b6db2509
DIFF: https://github.com/llvm/llvm-project/commit/847f4ef21b4a953bb6dd6477791e8d95b6db2509.diff

LOG: [X86] Use getAllOnesConstant instead of getConstant(-1). NFC (#114299)

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 34bc5d76c15cea..22cba69af41f51 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -49321,7 +49321,7 @@ static SDValue combineVectorShiftImm(SDNode *N, SelectionDAG &DAG,
   if (!LogicalShift && ISD::isBuildVectorAllOnes(N0.getNode()))
     // N0 is all ones or undef. We guarantee that the bits shifted into the
     // result are all ones, not undef.
-    return DAG.getConstant(-1, SDLoc(N), VT);
+    return DAG.getAllOnesConstant(SDLoc(N), VT);
 
   auto MergeShifts = [&](SDValue X, uint64_t Amt0, uint64_t Amt1) {
     unsigned NewShiftVal = Amt0 + Amt1;


        


More information about the llvm-commits mailing list