[llvm] [X86] Recognize POP/ADD/SUB modifying rsp in getSPAdjust. (PR #114265)
Evgenii Kudriashov via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 30 16:00:12 PDT 2024
e-kud wrote:
> > @daniel-zabawa any tests?
>
> I am open to suggestions on how to cover this. The potential bug in prolog/epilog is contingent on having a frame object referenced in a call sequence, following a previous call sequence which requires the frame pointer to be spilled.
>
> I don't know any reliable way to create the code exposing the issue without MIR, but MIR also does not support serializing the attributes (FPClobberedByCall) required for the FP spill/restore to be generated.
Can we add this attribute to `llvm/lib/Target/X86/X86MachineFunctionInfo.h` similarly we have for `amxProgModel` and check with mir tests? It consumes `X86MachineFunctionInfo` that has `getFPClobberedByCall`.
https://github.com/llvm/llvm-project/pull/114265
More information about the llvm-commits
mailing list