[llvm] [Offload] Introduce offload-tblgen and initial new API implementation (PR #108413)
Joseph Huber via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 30 10:16:09 PDT 2024
jhuber6 wrote:
> > Generally I'm in favor of `ol_` as a prefix, `snake_case` for the C API, and `get_x` as the verbage.
>
> I'll update the prefix etc. Just wondering though do we want to prefer `olCamelCase` instead to better match the LLVM style rather than just do what omp does? IMO snake_case looks odd unless function parameters also use snake_case, and at that point it kind of pollutes the implementation code with that style
Tough to say, pretty much up to personal preference. We could probably make the argument for camelCase because it's used in CUDA, Vulkan, OpenCL, and OpenGL while AFAIK `snake_case` is only in HSA.
https://github.com/llvm/llvm-project/pull/108413
More information about the llvm-commits
mailing list