[llvm] [MemProf] Include <ctime> to avoid MSVC failure (PR #114246)

via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 08:04:55 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-pgo

Author: Teresa Johnson (teresajohnson)

<details>
<summary>Changes</summary>

My change in bb3915149a7c9b1660db9caebfc96343352e8454 added a call to
std::time which worked generally as there must be some transitive
include of <ctime>. However, I saw one MSVC bot failure:

InstrProfWriter.cpp(202): error C2039: 'time': is not a member of 'std'

from https://lab.llvm.org/buildbot/#/builders/63/builds/2325.

Presumably explictly including <ctime> should fix this.


---
Full diff: https://github.com/llvm/llvm-project/pull/114246.diff


1 Files Affected:

- (modified) llvm/lib/ProfileData/InstrProfWriter.cpp (+1) 


``````````diff
diff --git a/llvm/lib/ProfileData/InstrProfWriter.cpp b/llvm/lib/ProfileData/InstrProfWriter.cpp
index f09241681b92a5..0ab9f942a08589 100644
--- a/llvm/lib/ProfileData/InstrProfWriter.cpp
+++ b/llvm/lib/ProfileData/InstrProfWriter.cpp
@@ -29,6 +29,7 @@
 #include "llvm/Support/OnDiskHashTable.h"
 #include "llvm/Support/raw_ostream.h"
 #include <cstdint>
+#include <ctime>
 #include <memory>
 #include <string>
 #include <tuple>

``````````

</details>


https://github.com/llvm/llvm-project/pull/114246


More information about the llvm-commits mailing list