[llvm] [ConstantFold] Fold `tgamma` and `tgammaf` when the input parameter is a constant value. (PR #114065)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 30 08:03:25 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-analysis
Author: None (c8ef)
<details>
<summary>Changes</summary>
This patch adds support for constant folding for the `tgamma` and `tgammaf` libc functions.
---
Full diff: https://github.com/llvm/llvm-project/pull/114065.diff
2 Files Affected:
- (modified) llvm/lib/Analysis/ConstantFolding.cpp (+17-3)
- (added) llvm/test/Transforms/InstCombine/tgamma.ll (+237)
``````````diff
diff --git a/llvm/lib/Analysis/ConstantFolding.cpp b/llvm/lib/Analysis/ConstantFolding.cpp
index c5a2c2f52f8dc2..19327c5c5afb7b 100644
--- a/llvm/lib/Analysis/ConstantFolding.cpp
+++ b/llvm/lib/Analysis/ConstantFolding.cpp
@@ -57,6 +57,7 @@
#include <cassert>
#include <cerrno>
#include <cfenv>
+#include <cfloat>
#include <cmath>
#include <cstdint>
@@ -1698,9 +1699,9 @@ bool llvm::canConstantFoldCallTo(const CallBase *Call, const Function *F) {
Name == "sinh" || Name == "sinhf" ||
Name == "sqrt" || Name == "sqrtf";
case 't':
- return Name == "tan" || Name == "tanf" ||
- Name == "tanh" || Name == "tanhf" ||
- Name == "trunc" || Name == "truncf";
+ return Name == "tan" || Name == "tanf" || Name == "tanh" ||
+ Name == "tanhf" || Name == "trunc" || Name == "truncf" ||
+ Name == "tgamma" || Name == "tgammaf";
case '_':
// Check for various function names that get used for the math functions
// when the header files are preprocessed with the macro
@@ -2417,6 +2418,15 @@ static Constant *ConstantFoldScalarCall1(StringRef Name,
if (TLI->has(Func))
return ConstantFoldFP(erf, APF, Ty);
break;
+ case LibFunc_tgamma:
+ case LibFunc_tgammaf:
+ // NOTE: These boundaries are somewhat conservative.
+ if (TLI->has(Func) && (Ty->isDoubleTy() && (APF > APFloat(1 / DBL_MAX) &&
+ APF < APFloat(171.0)) ||
+ Ty->isFloatTy() && (APF > APFloat(1 / FLT_MAX) &&
+ APF < APFloat(35.0f))))
+ return ConstantFoldFP(tgamma, APF, Ty);
+ break;
case LibFunc_nearbyint:
case LibFunc_nearbyintf:
case LibFunc_rint:
@@ -3629,6 +3639,10 @@ bool llvm::isMathLibCallNoop(const CallBase *Call,
case LibFunc_sqrtf:
return Op.isNaN() || Op.isZero() || !Op.isNegative();
+ case LibFunc_tgamma:
+ case LibFunc_tgammaf:
+ return true;
+
// FIXME: Add more functions: sqrt_finite, atanh, expm1, log1p,
// maybe others?
default:
diff --git a/llvm/test/Transforms/InstCombine/tgamma.ll b/llvm/test/Transforms/InstCombine/tgamma.ll
new file mode 100644
index 00000000000000..e79687e41d8af5
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/tgamma.ll
@@ -0,0 +1,237 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+
+define float @tgammaf_const() {
+; CHECK-LABEL: define float @tgammaf_const() {
+; CHECK-NEXT: ret float 0x479A216280000000
+;
+ %r = call float @tgammaf(float 34.0)
+ ret float %r
+}
+
+define double @tgamma_const() {
+; CHECK-LABEL: define double @tgamma_const() {
+; CHECK-NEXT: ret double 0x605166C698CF183B
+;
+ %r = call double @tgamma(double 100.0)
+ ret double %r
+}
+
+define float @tgammaf_const_overflow() {
+; CHECK-LABEL: define float @tgammaf_const_overflow() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float 3.600000e+01)
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float 36.0)
+ ret float %r
+}
+
+define double @tgamma_const_overflow() {
+; CHECK-LABEL: define double @tgamma_const_overflow() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double 1.720000e+02)
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double 172.0)
+ ret double %r
+}
+
+define float @tgammaf_minus_one() {
+; CHECK-LABEL: define float @tgammaf_minus_one() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float -1.000000e+00)
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float -1.000000e+00)
+ ret float %r
+}
+
+define double @tgamma_minus_one() {
+; CHECK-LABEL: define double @tgamma_minus_one() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double -1.000000e+00)
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double -1.000000e+00)
+ ret double %r
+}
+
+define float @tgammaf_minus_one_memory_none() {
+; CHECK-LABEL: define float @tgammaf_minus_one_memory_none() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float -1.000000e+00) #[[ATTR1:[0-9]+]]
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float -1.000000e+00) readnone
+ ret float %r
+}
+
+define double @tgamma_minus_one_memory_none() {
+; CHECK-LABEL: define double @tgamma_minus_one_memory_none() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double -1.000000e+00) #[[ATTR1]]
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double -1.000000e+00) readnone
+ ret double %r
+}
+
+define float @tgammaf_zero() {
+; CHECK-LABEL: define float @tgammaf_zero() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float 0.000000e+00)
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float 0.000000e+00)
+ ret float %r
+}
+
+define double @tgamma_zero() {
+; CHECK-LABEL: define double @tgamma_zero() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double 0.000000e+00)
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double 0.000000e+00)
+ ret double %r
+}
+
+define float @tgammaf_neg_zero() {
+; CHECK-LABEL: define float @tgammaf_neg_zero() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float -0.000000e+00)
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float -0.000000e+00)
+ ret float %r
+}
+
+define double @tgamma_neg_zero() {
+; CHECK-LABEL: define double @tgamma_neg_zero() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double -0.000000e+00)
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double -0.000000e+00)
+ ret double %r
+}
+
+define float @tgammaf_inf() {
+; CHECK-LABEL: define float @tgammaf_inf() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float 0x7FF0000000000000)
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float 0x7FF0000000000000)
+ ret float %r
+}
+
+define double @tgamma_inf() {
+; CHECK-LABEL: define double @tgamma_inf() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double 0x7FF0000000000000)
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double 0x7FF0000000000000)
+ ret double %r
+}
+
+define float @tgammaf_inf_memory_none() {
+; CHECK-LABEL: define float @tgammaf_inf_memory_none() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float 0x7FF0000000000000) #[[ATTR1]]
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float 0x7FF0000000000000) readnone
+ ret float %r
+}
+
+define double @tgamma_inf_memory_none() {
+; CHECK-LABEL: define double @tgamma_inf_memory_none() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double 0x7FF0000000000000) #[[ATTR1]]
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double 0x7FF0000000000000) readnone
+ ret double %r
+}
+
+define float @tgammaf_neg_inf() {
+; CHECK-LABEL: define float @tgammaf_neg_inf() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float 0xFFF0000000000000)
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float 0xFFF0000000000000)
+ ret float %r
+}
+
+define double @tgamma_neg_inf() {
+; CHECK-LABEL: define double @tgamma_neg_inf() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double 0xFFF0000000000000)
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double 0xFFF0000000000000)
+ ret double %r
+}
+
+define float @tgammaf_neg_inf_memory_none() {
+; CHECK-LABEL: define float @tgammaf_neg_inf_memory_none() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float 0xFFF0000000000000) #[[ATTR1]]
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float 0xFFF0000000000000) readnone
+ ret float %r
+}
+
+define double @tgamma_neg_inf_memory_none() {
+; CHECK-LABEL: define double @tgamma_neg_inf_memory_none() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double 0xFFF0000000000000) #[[ATTR1]]
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double 0xFFF0000000000000) readnone
+ ret double %r
+}
+
+define float @tgammaf_nan() {
+; CHECK-LABEL: define float @tgammaf_nan() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float 0x7FF8000000000000)
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float 0x7FF8000000000000)
+ ret float %r
+}
+
+define double @tgamma_nan() {
+; CHECK-LABEL: define double @tgamma_nan() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double 0x7FF8000000000000)
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double 0x7FF8000000000000)
+ ret double %r
+}
+
+define float @tgammaf_nan_memory_none() {
+; CHECK-LABEL: define float @tgammaf_nan_memory_none() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float 0x7FF8000000000000) #[[ATTR1]]
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float 0x7FF8000000000000) readnone
+ ret float %r
+}
+
+define double @tgamma_nan_memory_none() {
+; CHECK-LABEL: define double @tgamma_nan_memory_none() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double 0x7FF8000000000000) #[[ATTR1]]
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double 0x7FF8000000000000) readnone
+ ret double %r
+}
+
+define float @tgammaf_poison() {
+; CHECK-LABEL: define float @tgammaf_poison() {
+; CHECK-NEXT: [[R:%.*]] = call float @tgammaf(float poison)
+; CHECK-NEXT: ret float [[R]]
+;
+ %r = call float @tgammaf(float poison)
+ ret float %r
+}
+
+define double @tgamma_poison() {
+; CHECK-LABEL: define double @tgamma_poison() {
+; CHECK-NEXT: [[R:%.*]] = call double @tgamma(double poison)
+; CHECK-NEXT: ret double [[R]]
+;
+ %r = call double @tgamma(double poison)
+ ret double %r
+}
+
+declare float @tgammaf(float) willreturn
+declare double @tgamma(double) willreturn
``````````
</details>
https://github.com/llvm/llvm-project/pull/114065
More information about the llvm-commits
mailing list