[libcxx] [llvm] Debug windows failures for localization changes (PR #114228)

via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 07:41:47 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 6563ed3162d16e7f067dda554e96d0c9d476f207 1074d336ce915830a5bd2efcdbdb670fd82eef3a --extensions ,h,cpp -- libcxx/include/__locale_dir/locale_base_api.h libcxx/include/__locale_dir/locale_base_api/bsd_locale_defaults.h libcxx/include/__locale_dir/locale_base_api/bsd_locale_fallbacks.h libcxx/include/locale libcxx/src/locale.cpp libcxx/test/std/re/re.traits/getloc.pass.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/src/locale.cpp b/libcxx/src/locale.cpp
index fe4affb10d..adc9805b18 100644
--- a/libcxx/src/locale.cpp
+++ b/libcxx/src/locale.cpp
@@ -237,14 +237,14 @@ locale::__imp::__imp(const string& name, size_t refs) : facet(refs), facets_(N),
       if (facets_[i])
         facets_[i]->__add_shared();
 
-#define _DOIT(...)                                            \
-    do {                                                      \
-      std::fprintf(stderr, "Creating " #__VA_ARGS__ "\n");    \
-      auto* the_facet = new __VA_ARGS__(name_);               \
-                                                              \
-      std::fprintf(stderr, "Installing " #__VA_ARGS__ "\n");  \
-      install(the_facet);                                     \
-    } while (false)
+#define _DOIT(...)                                                                                                     \
+  do {                                                                                                                 \
+    std::fprintf(stderr, "Creating " #__VA_ARGS__ "\n");                                                               \
+    auto* the_facet = new __VA_ARGS__(name_);                                                                          \
+                                                                                                                       \
+    std::fprintf(stderr, "Installing " #__VA_ARGS__ "\n");                                                             \
+    install(the_facet);                                                                                                \
+  } while (false)
 
     _DOIT(collate_byname<char>);
 #ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS

``````````

</details>


https://github.com/llvm/llvm-project/pull/114228


More information about the llvm-commits mailing list