[llvm] [llvm-objdump] Implement decoding auxiliary header for xcoff with llvm-objdump --private-headers (PR #105682)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 02:14:22 PDT 2024


================
@@ -41,14 +42,34 @@ class XCOFFDumper : public objdump::Dumper {
 private:
   void printPrivateHeaders() override;
   void printFileHeader();
-  FormattedString formatName(StringRef Name);
+  void printAuxiliaryHeader();
+  void printAuxiliaryHeader(const XCOFFAuxiliaryHeader32 *AuxHeader);
+  void printAuxiliaryHeader(const XCOFFAuxiliaryHeader64 *AuxHeader);
+  template <typename MemberOfAuxiliaryHeader, typename XCOFFAuxiliaryHeader>
----------------
jh7370 wrote:

```suggestion
  template <typename AuxHeaderMemberType, typename XCOFFAuxiliaryHeader>
```
I suggest this name is better. As things stand, `MemberOfAuxiliaryHeader` looks like a variable name, not a type name.

https://github.com/llvm/llvm-project/pull/105682


More information about the llvm-commits mailing list