[llvm] PowerPC/VSX: Select FMINNUM_IEEE and FMAXNUM_IEEE (PR #112195)

Lei Huang via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 29 13:46:15 PDT 2024


================
@@ -775,6 +775,10 @@ PPCTargetLowering::PPCTargetLowering(const PPCTargetMachine &TM,
     setOperationAction(ISD::FMAXNUM_IEEE, MVT::f32, Legal);
     setOperationAction(ISD::FMINNUM_IEEE, MVT::f64, Legal);
     setOperationAction(ISD::FMINNUM_IEEE, MVT::f32, Legal);
+    setOperationAction(ISD::FMAXNUM, MVT::f64, Legal);
+    setOperationAction(ISD::FMAXNUM, MVT::f32, Legal);
+    setOperationAction(ISD::FMINNUM, MVT::f64, Legal);
+    setOperationAction(ISD::FMINNUM, MVT::f32, Legal);
----------------
lei137 wrote:

My concern with the break down here is that it will leave things in an invalid state.  Shouldn't step 1-4 be done together for the compiler behaviour to be valid?  At the minimun, step 4, test casess should be added with the corresponding code change?

https://github.com/llvm/llvm-project/pull/112195


More information about the llvm-commits mailing list