[llvm] 9e37cbb - [ORC] Add some missing FIXMEs, move a temporary Error into an if condition.

[Lang Hames via llvm-commits]

Author: Lang Hames
Date: 2024-10-29T11:12:48-07:00
New Revision: 9e37cbb469c0ec2fdbf4e3e7b0d9a2938ac30b01

URL: https://github.com/llvm/llvm-project/commit/9e37cbb469c0ec2fdbf4e3e7b0d9a2938ac30b01
DIFF: https://github.com/llvm/llvm-project/commit/9e37cbb469c0ec2fdbf4e3e7b0d9a2938ac30b01.diff

LOG: [ORC] Add some missing FIXMEs, move a temporary Error into an if condition.

Added: 
    

Modified: 
    llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp b/llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp
index 4ef217e6c562db..81294cad4d7d42 100644
--- a/llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/JITLinkRedirectableSymbolManager.cpp
@@ -52,17 +52,18 @@ void JITLinkRedirectableSymbolManager::emitRedirectableSymbols(
     return;
   }
 
+  // FIXME: return stubs to the pool here too.
   if (auto Err = R->replace(absoluteSymbols(NewSymbolDefs))) {
     ES.reportError(std::move(Err));
     R->failMaterialization();
     return;
   }
 
-  auto Err = R->withResourceKeyDo([&](ResourceKey Key) {
-    TrackedResources[Key].insert(TrackedResources[Key].end(), Symbols.begin(),
-                                 Symbols.end());
-  });
-  if (Err) {
+  // FIXME: return stubs to the pool here too.
+  if (auto Err = R->withResourceKeyDo([&](ResourceKey Key) {
+        TrackedResources[Key].insert(TrackedResources[Key].end(),
+                                     Symbols.begin(), Symbols.end());
+      })) {
     ES.reportError(std::move(Err));
     R->failMaterialization();
     return;