goldsteinn wrote: IMO since github doesn't have a great interface for reviewing single-commits in a series, you should split the first commit to its own proper NFC PR. https://github.com/llvm/llvm-project/pull/114061