[llvm] Remove llvm::shouldOptForSize() from Utils.h (PR #112630)

Ellis Hoag via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 28 12:25:18 PDT 2024


================
@@ -635,8 +636,12 @@ class GIMatchTableExecutor {
 
   bool shouldOptForSize(const MachineFunction *MF) const {
----------------
ellishg wrote:

Yes, I would like to remove this too, but this caused some build errors because of generated code. In fact, some implementors don't even check PGO.
https://github.com/llvm/llvm-project/blob/66bbbf2e951a486f972a5a54378e6791193ade60/llvm/include/llvm/CodeGen/FastISel.h#L520-L523

Since I'm less familiar with ISel, I thought I'd leave this alone for now.

https://github.com/llvm/llvm-project/pull/112630


More information about the llvm-commits mailing list