[llvm] Remove llvm::shouldOptForSize() from Utils.h (PR #112630)
Kyungwoo Lee via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 28 10:35:04 PDT 2024
================
@@ -635,8 +636,12 @@ class GIMatchTableExecutor {
bool shouldOptForSize(const MachineFunction *MF) const {
----------------
kyulee-com wrote:
I don't this this is from your change, but it's a bit confusing how `shouldOptForSize` differs from llvm::shouldOptimizeForSize. I guess this is specifically used for GISel, and as long as the current processing block is optimized for size, we consider this function optimized for size? But don't we derive this check for a block by checking its parent function? Basically, my understanding is that even if `shouldOptimizeForSize` for a function is false, shouldOptimizeForSize for a block that belongs to the function may be true. Here, it doesn't seem like that's the case.
https://github.com/llvm/llvm-project/pull/112630
More information about the llvm-commits
mailing list