[llvm] [ADT] Teach StringRef to derive from std::string_view (PR #113752)

Sat Oct 26 10:17:24 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-runtime-cuda-clang` running on `as-builder-7` while building `llvm` at step 7 "build-clang-default".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/7/builds/6300

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (build-clang-default) failure: cmake (failure)
...
3.417 [4591/130/129] Building CXX object projects/openmp/tools/archer/CMakeFiles/archer.dir/ompt-tsan.cpp.o
3.427 [4590/130/130] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/FileOutputBuffer.cpp.o
3.457 [4589/130/131] Building CXX object projects/openmp/tools/archer/CMakeFiles/archer_static.dir/ompt-tsan.cpp.o
3.459 [4588/130/132] Generating kmp_i18n_default.inc
3.467 [4587/130/133] Generating kmp_i18n_id.inc
3.499 [4586/130/134] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/BinaryStreamReader.cpp.o
3.510 [4585/130/135] Linking CXX static library lib/libarcher_static.a
3.548 [4584/130/136] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/PGOOptions.cpp.o
3.555 [4583/130/137] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/UnicodeNameToCodepoint.cpp.o
3.563 [4582/130/138] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/JSON.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/JSON.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/clang/lib/Support -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/lib/Support -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/clang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -UNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/JSON.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/JSON.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/JSON.cpp.o -c /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/lib/Support/JSON.cpp
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/lib/Support/JSON.cpp: In member function ‘llvm::Error llvm::json::Path::Root::getError() const’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/lib/Support/JSON.cpp:229:6: error: ambiguous overload for ‘operator<<’ (operand types are ‘llvm::raw_string_ostream’ and ‘const llvm::StringLiteral’)
  229 |   OS << (ErrorMessage.empty() ? "invalid JSON contents" : ErrorMessage);
      |   ~~ ^~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |   |                           |
      |   llvm::raw_string_ostream    const llvm::StringLiteral
In file included from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include/llvm/Support/Error.h:25,
                 from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include/llvm/Support/JSON.h:54,
                 from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/lib/Support/JSON.cpp:9:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include/llvm/Support/raw_ostream.h:224:16: note: candidate: ‘llvm::raw_ostream& llvm::raw_ostream::operator<<(llvm::StringRef)’
  224 |   raw_ostream &operator<<(StringRef Str) {
      |                ^~~~~~~~
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include/llvm/Support/raw_ostream.h:265:16: note: candidate: ‘llvm::raw_ostream& llvm::raw_ostream::operator<<(const string_view&)’
  265 |   raw_ostream &operator<<(const std::string_view &Str) {
      |                ^~~~~~~~
In file included from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/lib/Support/JSON.cpp:9:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include/llvm/Support/JSON.h:1089:27: note: candidate: ‘llvm::raw_ostream& llvm::json::operator<<(llvm::raw_ostream&, const llvm::json::Value&)’
 1089 | inline llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, const Value &V) {
      |                           ^~~~~~~~
In file included from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include/llvm/Support/Error.h:17,
                 from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include/llvm/Support/JSON.h:54,
                 from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/lib/Support/JSON.cpp:9:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include/llvm/ADT/Twine.h:572:23: note: candidate: ‘llvm::raw_ostream& llvm::operator<<(llvm::raw_ostream&, const llvm::Twine&)’
  572 |   inline raw_ostream &operator<<(raw_ostream &OS, const Twine &RHS) {
      |                       ^~~~~~~~
3.563 [4582/129/139] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/WithColor.cpp.o
3.574 [4582/128/140] Linking CXX shared library lib/libarcher.so
3.597 [4582/127/141] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/GraphWriter.cpp.o
3.604 [4582/126/142] Building CXX object lib/TableGen/CMakeFiles/LLVMTableGen.dir/Error.cpp.o
3.655 [4582/125/143] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Process.cpp.o
3.686 [4582/124/144] Building CXX object lib/Extensions/CMakeFiles/LLVMExtensions.dir/Extensions.cpp.o
3.690 [4582/123/145] Building CXX object projects/openmp/runtime/src/CMakeFiles/omp.dir/kmp_debug.cpp.o
3.731 [4582/122/146] Building CXX object projects/openmp/runtime/src/CMakeFiles/omp.dir/kmp_itt.cpp.o
3.751 [4582/121/147] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Error.cpp.o
3.754 [4582/120/148] Building CXX object projects/openmp/runtime/src/CMakeFiles/omp.dir/kmp_alloc.cpp.o
3.778 [4582/119/149] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Parallel.cpp.o
3.793 [4582/118/150] Building CXX object projects/openmp/runtime/src/CMakeFiles/omp.dir/kmp_csupport.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/113752