[llvm] [docs] Update docs on code-review process (PR #111735)
Jakub Kuderski via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 25 20:55:09 PDT 2024
================
@@ -150,14 +150,20 @@ almost always associated with a message containing the text "LGTM" (which
stands for Looks Good To Me). Only approval from a single reviewer is required.
When providing an unqualified LGTM (approval to commit), it is the
-responsibility of the reviewer to have reviewed all of the discussion and
+responsibility of the reviewer to have reviewed all of the prior discussion and
feedback from all reviewers ensuring that all feedback has been addressed and
that all other reviewers will almost surely be satisfied with the patch being
approved. If unsure, the reviewer should provide a qualified approval, (e.g.,
"LGTM, but please wait for @someone, @someone_else"). You may also do this if
you are fairly certain that a particular community member will wish to review,
even if that person hasn't done so yet.
+If additional feedback is provided after acceptance (by the same reviewer or
+another), the author should use their best judgement in deciding whether that
+feedback can be incorporated into the change without comment (say a typo) or
+requires further review discussion. More substantial comments (e.g. about the
----------------
kuhar wrote:
Let's keep this consistent with the style used above
```suggestion
requires further review discussion. More substantial comments (e.g., about the
```
https://github.com/llvm/llvm-project/pull/111735
More information about the llvm-commits
mailing list