[compiler-rt] [sanitizer_common] AND signals in BlockSignals instead of deleting (PR #113443)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 25 13:15:55 PDT 2024


================
@@ -164,33 +164,45 @@ void SetSigProcMask(__sanitizer_sigset_t *set, __sanitizer_sigset_t *oldset) {
   CHECK_EQ(0, internal_sigprocmask(SIG_SETMASK, set, oldset));
 }
 
+// Deletes the specified signal from newset, if it is not present in oldset
+// Equivalently: newset[signum] = newset[signum] & oldset[signum]
+static void KeepUnblocked(__sanitizer_sigset_t &newset,
----------------
vitalybuka wrote:

I believe `internal_` convention is for internal `libc` alternative.
This have no equivalent, so should follow regular conventions.

Also this is very specific to `BlockSignals` goals, so should be `static`.



https://github.com/llvm/llvm-project/pull/113443


More information about the llvm-commits mailing list