[llvm] [TableGen] [NFC] Refine TableGen code to comply with `clang-tidy` checks (PR #113318)
Rahul Joshi via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 25 12:32:13 PDT 2024
jurahul wrote:
Sounds good. Breaking it into smaller PR for independent changes is welcome.
On Fri, Oct 25, 2024 at 12:07 PM Jerry Sun ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In llvm/utils/TableGen/CallingConvEmitter.cpp
> <https://github.com/llvm/llvm-project/pull/113318#discussion_r1817219538>:
>
> > @@ -34,12 +34,12 @@ class CallingConvEmitter {
> public:
> explicit CallingConvEmitter(const RecordKeeper &R) : Records(R) {}
>
> - void run(raw_ostream &o);
> + void run(raw_ostream &O);
>
> @jurahul <https://github.com/jurahul> should I create a new PR for this
> change? It looks like there are few other files that also needs this
> modification. I think it might introduce too many changed files in this PR.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/113318#discussion_r1817219538>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APRMUB6HN7XOKBUTENSRQTLZ5KJGHAVCNFSM6AAAAABQMSTYAKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJWGIYDEMBZG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
https://github.com/llvm/llvm-project/pull/113318
More information about the llvm-commits
mailing list