[llvm] [InstCombine] Missed optimization: Fold (sext(a) & c1) == c2 to (a & c3) == trunc(c2) (PR #112646)

via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 25 04:35:52 PDT 2024


================
@@ -7687,6 +7687,30 @@ Instruction *InstCombinerImpl::visitICmpInst(ICmpInst &I) {
   if (Instruction *Res = foldReductionIdiom(I, Builder, DL))
     return Res;
 
+  {
+    Value *A;
+    const APInt *C1, *C2;
+    ICmpInst::Predicate PredEq = ICmpInst::ICMP_EQ;
+    if (I.getPredicate() == PredEq) {
+      // c2 must be positive
+      // sext(a) & c1 == c2 --> a & c3 == trunc(c2)
+      if (match(Op0, m_And(m_SExtLike(m_Value(A)), m_APInt(C1))) && match(Op1, m_APInt(C2))) {
+        if (C2->isNonNegative()) {
----------------
XChy wrote:

`c2` must be non-negative at the bitwidth of `a`. For example, if `a` is an 8-bit integer and `c2` is an 32-bit integer, the leading 25 bits of `c2` should be zeros.
Here you are actually checking if `c2` is non-negative at the bitwidth of `c2`.

https://github.com/llvm/llvm-project/pull/112646


More information about the llvm-commits mailing list