[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)
Alexey Bader via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 23 22:16:37 PDT 2024
================
@@ -582,6 +582,10 @@ class Driver {
/// @name Helper Methods
/// @{
+ /// MakeSYCLDeviceTriple - Returns the SYCL device triple for the
+ /// specified ArchType.
+ llvm::Triple MakeSYCLDeviceTriple(StringRef TargetArch = "spir64") const;
----------------
bader wrote:
```suggestion
/// getSYCLDeviceTriple - Returns the SYCL device triple for the
/// specified ArchType.
llvm::Triple getSYCLDeviceTriple(StringRef TargetArch = "spir64") const;
```
Let's align with the rest of the helper functions and use "get".
The coding style says the name should start with the lower case letter. https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
https://github.com/llvm/llvm-project/pull/107493
More information about the llvm-commits
mailing list