[llvm] Promote 32bit pseudo instr that infer extsw removal to 64bit in PPCMIPeephole (PR #85451)
zhijian lin via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 23 10:58:10 PDT 2024
================
@@ -5234,6 +5234,216 @@ bool PPCInstrInfo::isTOCSaveMI(const MachineInstr &MI) const {
// We limit the max depth to track incoming values of PHIs or binary ops
// (e.g. AND) to avoid excessive cost.
const unsigned MAX_BINOP_DEPTH = 1;
+
+// This function will promote the instruction which defines the register `Reg`
+// in the parameter from a 32-bit to a 64-bit instruction if needed. The logic
+// used to check whether an instruction needs to be promoted or not is similar
+// to the logic used to check whether or not a defined register is sign or zero
+// extended within the function PPCInstrInfo::isSignOrZeroExtended.
+// Additionally, the `promoteInstr32To64ForElimEXTSW` function is recursive.
+// BinOpDepth does not count all of the recursions. The parameter BinOpDepth is
+// incremented only when `promoteInstr32To64ForElimEXTSW` calls itself more
+// than once. This is done to prevent exponential recursion.
+void PPCInstrInfo::promoteInstr32To64ForElimEXTSW(const Register &Reg,
+ MachineRegisterInfo *MRI,
+ unsigned BinOpDepth,
+ LiveVariables *LV) const {
+ if (!Reg.isVirtual())
+ return;
+
+ MachineInstr *MI = MRI->getVRegDef(Reg);
+ if (!MI)
+ return;
+
+ unsigned Opcode = MI->getOpcode();
+ bool HasNonSignedExtInstrPromoted = false;
+ int NewOpcode = -1;
+
+ std::unordered_map<unsigned, unsigned> OpcodeMap = {
+ {PPC::OR, PPC::OR8}, {PPC::ISEL, PPC::ISEL8},
+ {PPC::ORI, PPC::ORI8}, {PPC::XORI, PPC::XORI8},
+ {PPC::ORIS, PPC::ORIS8}, {PPC::XORIS, PPC::XORIS8},
+ {PPC::AND, PPC::AND8}};
+
+ // Check if the Opcode is in the map.
+ auto It = OpcodeMap.find(Opcode);
+ if (It != OpcodeMap.end()) {
+ // Set the new opcode to the mapped 64-bit version.
+ NewOpcode = It->second;
+ HasNonSignedExtInstrPromoted = true;
+ }
+
+ switch (Opcode) {
+ case PPC::OR:
+ case PPC::ISEL:
+ case PPC::OR8:
+ case PPC::PHI: {
+ if (BinOpDepth >= MAX_BINOP_DEPTH)
+ break;
+ unsigned OperandEnd = 3, OperandStride = 1;
+ if (Opcode == PPC::PHI) {
+ OperandEnd = MI->getNumOperands();
+ OperandStride = 2;
+ }
+
+ for (unsigned I = 1; I < OperandEnd; I += OperandStride) {
+ assert(MI->getOperand(I).isReg() && "Operand must be register");
+ promoteInstr32To64ForElimEXTSW(MI->getOperand(I).getReg(), MRI,
+ BinOpDepth + 1, LV);
+ }
+
+ break;
+ }
+ case PPC::COPY: {
+ // Refers to the logic of the `case PPC::COPY` statement in the function
+ // PPCInstrInfo::isSignOrZeroExtended().
+
+ Register SrcReg = MI->getOperand(1).getReg();
+ // In both ELFv1 and v2 ABI, method parameters and the return value
+ // are sign- or zero-extended.
+ const MachineFunction *MF = MI->getMF();
+ if (!MF->getSubtarget<PPCSubtarget>().isSVR4ABI()) {
+ // If this is a copy from another register, we recursively promote the
+ // source.
+ promoteInstr32To64ForElimEXTSW(SrcReg, MRI, BinOpDepth, LV);
+ return;
+ }
+
+ // From here on everything is SVR4ABI. COPY will be eliminated in the other
+ // pass, we do not need promote the COPY pseudo opcode.
+
+ if (SrcReg != PPC::X3)
+ // If this is a copy from another register, we recursively promote the
+ // source.
+ promoteInstr32To64ForElimEXTSW(SrcReg, MRI, BinOpDepth, LV);
+ return;
+ }
+ case PPC::ORI:
+ case PPC::XORI:
+ case PPC::ORIS:
+ case PPC::XORIS:
+ case PPC::ORI8:
+ case PPC::XORI8:
+ case PPC::ORIS8:
+ case PPC::XORIS8:
+ promoteInstr32To64ForElimEXTSW(MI->getOperand(1).getReg(), MRI, BinOpDepth,
+ LV);
+ break;
+ case PPC::AND:
+ case PPC::AND8:
+ if (BinOpDepth >= MAX_BINOP_DEPTH)
+ break;
+
+ promoteInstr32To64ForElimEXTSW(MI->getOperand(1).getReg(), MRI,
+ BinOpDepth + 1, LV);
+ promoteInstr32To64ForElimEXTSW(MI->getOperand(2).getReg(), MRI,
+ BinOpDepth + 1, LV);
+ break;
+ }
+
+ const PPCInstrInfo *TII =
+ MI->getMF()->getSubtarget<PPCSubtarget>().getInstrInfo();
+ if (!TII->isSExt32To64(Opcode) && !HasNonSignedExtInstrPromoted)
+ return;
+
+ const TargetRegisterClass *RC = MRI->getRegClass(Reg);
+
+ if (RC == &PPC::G8RCRegClass || RC == &PPC::G8RC_and_G8RC_NOX0RegClass)
+ return;
----------------
diggerlin wrote:
we can not move the checking to top, because even the RegClass of the `reg` is `PPC::G8RCRegClass` or `PPC::G8RC_and_G8RC_NOX0RegClass` , we still need to check whether we need to logic in the `switch` statement
for example, `COPY` from PPC::GPRCRegClass to PPC::G8RCRegClass, we still need to do `promoteInstr32To64ForElimEXTSW`
https://github.com/llvm/llvm-project/pull/85451
More information about the llvm-commits
mailing list