[llvm] [mlir] [LLVM][TableGen] Change `RecordKeeper::getClass` to return const pointer (PR #112261)

[Rahul Joshi via llvm-commits]

jurahul wrote:

That link seems to about MLIR whereas this change is in LLVM tablegen,
which follows LLVM’s style of using const pointers. In fact, this is my
last change in this area, at this point most other TableGen Record and
related pointers are const.

On Tue, Oct 22, 2024 at 10:35 PM Jakub Kuderski ***@***.***>
wrote:

> ***@***.**** commented on this pull request.
>
> I wonder if we should expand on the 'const correctness' coding style rules
> before propagating const across these APIs? IR constructs are not designed
> for const correctness <https://mlir.llvm.org/docs/Rationale/UsageOfConst/>
> .
>
> In the past @Mogball <https://github.com/Mogball> argued that this was
> non-goal even for types outside of the core IR.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/112261#pullrequestreview-2387214321>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APRMUB6A6THJSIYKHJJJVMDZ44YRTAVCNFSM6AAAAABP5YFSRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBXGIYTIMZSGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/112261