[llvm] [llvm][docs] Add Approvals section to GitHub guide (PR #113434)
David Spickett via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 23 05:55:42 PDT 2024
================
@@ -138,10 +138,16 @@ you won't encounter merge conflicts when landing the PR.
collaborating with others on a single branch, be careful how and when you push
changes. ``--force-with-lease`` may be useful in this situation.
+Approvals
+---------
+
+Before merging a PR you must have the required approvals. See
+:ref:`lgtm_how_a_patch_is_accepted` for more details.
+
Landing your change
-------------------
-When your PR has been accepted you can merge your changes.
+When your PR has been apporoved you can merge your changes.
----------------
DavidSpickett wrote:
Fixed, thanks.
https://github.com/llvm/llvm-project/pull/113434
More information about the llvm-commits
mailing list