[llvm] [lit][aix] Always use internal lit shell on AIX (PR #113355)

Daniel Paoliello via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 11:16:19 PDT 2024


https://github.com/dpaoliello created https://github.com/llvm/llvm-project/pull/113355

Diff on AIX doesn't have all the required features used in tests (see <https://github.com/llvm/llvm-project/pull/108871> and <https://github.com/llvm/llvm-project/pull/112997#issuecomment-2429656192>), so always use the internal shell.

>From 321318790b452880f085f75da39763a3573a7e7f Mon Sep 17 00:00:00 2001
From: "Daniel Paoliello (HE/HIM)" <danpao at microsoft.com>
Date: Tue, 22 Oct 2024 11:14:59 -0700
Subject: [PATCH] [lit][aix] Always use internal lit shell on AIX

---
 llvm/utils/lit/lit/llvm/config.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index 5f762ec7f3514a..1ef5796cd32e44 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -57,6 +57,13 @@ def __init__(self, lit_config, config):
                 self.lit_config.note("using lit tools: {}".format(path))
                 lit_path_displayed = True
 
+        if platform.system() == "AIX":
+            # Diff on AIX doesn't have all the required features (see
+            # https://github.com/llvm/llvm-project/pull/108871 and
+            # https://github.com/llvm/llvm-project/pull/112997#issuecomment-2429656192)
+            # so always use the internal shell.
+            self.use_lit_shell = True
+
         if platform.system() == "OS/390":
             self.with_environment("_BPXK_AUTOCVT", "ON")
             self.with_environment("_TAG_REDIR_IN", "TXT")



More information about the llvm-commits mailing list