[llvm] [TableGen] [code-cleanup] Refine TableGen code to comply with `clang-tidy` checks and remove unused imports (PR #113318)

Rahul Joshi via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 09:01:01 PDT 2024


jurahul wrote:

https://discourse.llvm.org/t/widescale-clang-tidy-or-similar-based-cleanup/44527

Looks like wide scale code reformatting is discouraged but other cleanups
like this one are welcome.

For this case, if we can split into 2: unused header removal and rename
things to conform to LLVM coding standards seems reasonable.

On Tue, Oct 22, 2024 at 8:43 AM Rahul Joshi ***@***.***> wrote:

> Thanks. Though it might to get clarity on LLVM’s policy for such changes
> if any. I’ll check if this has come up before and if there is any existing
> guidance.
>
> On Tue, Oct 22, 2024 at 8:28 AM Paul C. Anagnostopoulos <
> ***@***.***> wrote:
>
>> I'm not actively working on TableGen these days, so you don't really need
>> my opinion. But these cleanups are a great idea and so go for it.
>>
>>>> Reply to this email directly, view it on GitHub
>> <https://github.com/llvm/llvm-project/pull/113318#issuecomment-2429598295>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/APRMUB3SSILWRLHT64LLPL3Z4ZVKRAVCNFSM6AAAAABQMSTYAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZGU4TQMRZGU>
>> .
>> You are receiving this because your review was requested.Message ID:
>> ***@***.***>
>>
>


https://github.com/llvm/llvm-project/pull/113318


More information about the llvm-commits mailing list