[llvm] [TableGen] Added submulticlass typechecking to template arg values. (PR #112904)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 01:04:48 PDT 2024


jayfoad wrote:

Thanks for the updates. The change in behaviour makes sense to me, although it seems like `CheckTemplateArgValues` is doing more than just checking -- it is actually casting template arguments to the declared type, which can change their values.

The AMDGPU fix still doesn't look right. The intention of the code is clearly that when you pass in `-1`, the `!eq(..., -1)` test should be `true`.

https://github.com/llvm/llvm-project/pull/112904


More information about the llvm-commits mailing list