[llvm] [SandboxVectorizer] New class to actually collect and manage seeds (PR #112979)

Mon Oct 21 16:05:30 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `llvm` at step 8 "Add check check-llvm".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/7373

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 8 (Add check check-llvm) failure: test (failure)
...
[660/671] Linking CXX executable unittests/Transforms/Scalar/ScalarTests
[661/671] Linking CXX executable unittests/ExecutionEngine/MCJIT/MCJITTests
[662/671] Linking CXX executable unittests/CodeGen/GlobalISel/GlobalISelTests
[663/671] Linking CXX executable unittests/tools/llvm-exegesis/LLVMExegesisTests
[664/671] Linking CXX executable unittests/CodeGen/CodeGenTests
[665/671] Linking CXX executable unittests/MIR/MIRTests
[666/671] Linking CXX executable unittests/DebugInfo/DWARF/DebugInfoDWARFTests
[667/671] Linking CXX executable unittests/Target/AMDGPU/AMDGPUTests
[668/671] Linking CXX executable unittests/Target/TargetMachineCTests
[669/671] Building CXX object unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o
FAILED: unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o 
ccache /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/unittests/Transforms/Vectorize/SandboxVectorizer -I/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/llvm/unittests/Transforms/Vectorize/SandboxVectorizer -I/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/include -I/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/llvm/include -I/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googletest/include -I/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o -MF unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o.d -o unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o -c /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp
In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:274,
                 from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/llvm/include/llvm/Testing/Support/SupportHelpers.h:17,
                 from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp:20:
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googlemock/include/gmock/internal/gmock-internal-utils.h: In instantiation of ‘class testing::internal::StlContainerView<llvm::sandboxir::SeedBundle>’:
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:3786:44:   required from ‘testing::internal::ElementsAreMatcher<MatcherTuple>::operator testing::Matcher<T>() const [with Container = const llvm::sandboxir::SeedBundle&; MatcherTuple = std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*>]’
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:373:12:   required from ‘static testing::Matcher<T> testing::internal::MatcherCastImpl<T, M>::CastImpl(const M&, std::true_type, std::integral_constant<bool, Ignore>) [with bool Ignore = false; T = const llvm::sandboxir::SeedBundle&; M = testing::internal::ElementsAreMatcher<std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*> >; std::true_type = std::integral_constant<bool, true>]’
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:355:20:   required from ‘static testing::Matcher<T> testing::internal::MatcherCastImpl<T, M>::Cast(const M&) [with T = const llvm::sandboxir::SeedBundle&; M = testing::internal::ElementsAreMatcher<std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*> >]’
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:515:47:   required from ‘testing::Matcher<T> testing::MatcherCast(const M&) [with T = const llvm::sandboxir::SeedBundle&; M = testing::internal::ElementsAreMatcher<std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*> >]’
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:522:24:   required from ‘testing::Matcher<T> testing::SafeMatcherCast(const M&) [with T = const llvm::sandboxir::SeedBundle&; M = testing::internal::ElementsAreMatcher<std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*> >]’
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:1591:64:   required from ‘testing::AssertionResult testing::internal::PredicateFormatterFromMatcher<M>::operator()(const char*, const T&) const [with T = llvm::sandboxir::SeedBundle; M = testing::internal::ElementsAreMatcher<std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*> >]’
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp:316:3:   required from here
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/third-party/unittest/googlemock/include/gmock/internal/gmock-internal-utils.h:352:15: error: invalid abstract return type ‘llvm::sandboxir::SeedBundle’
  352 |   static type Copy(const RawContainer& container) { return container; }
      |               ^~~~
In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp:9:
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h:27:7: note:   because the following virtual functions are pure within ‘llvm::sandboxir::SeedBundle’:
   27 | class SeedBundle {
      |       ^~~~~~~~~~
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h:57:16: note: 	‘virtual void llvm::sandboxir::SeedBundle::insert(llvm::sandboxir::Instruction*, llvm::ScalarEvolution&)’
   57 |   virtual void insert(Instruction *I, ScalarEvolution &SE) = 0;
      |                ^~~~~~
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/112979