[llvm] [SandboxVectorizer] New class to actually collect and manage seeds (PR #112979)

Mon Oct 21 15:43:17 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/7157

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
7.169 [108/34/98] Linking CXX executable bin/verify-uselistorder
7.180 [107/34/99] Linking CXX executable bin/obj2yaml
7.211 [106/34/100] Linking CXX executable unittests/DebugInfo/Symbolizer/DebugInfoSymbolizerTests
7.241 [105/34/101] Linking CXX executable unittests/Bitcode/BitcodeTests
7.245 [104/34/102] Linking CXX executable unittests/DebugInfo/GSYM/DebugInfoGSYMTests
7.310 [103/34/103] Linking CXX executable unittests/InterfaceStub/InterfaceStubTests
7.312 [102/34/104] Linking CXX executable bin/llvm-link
7.327 [101/34/105] Linking CXX executable unittests/Debuginfod/DebuginfodTests
7.409 [100/34/106] Linking CXX executable tools/clang/tools/extra/unittests/clang-query/ClangQueryTests
7.463 [99/34/107] Building CXX object unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o
FAILED: unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/unittests/Transforms/Vectorize/SandboxVectorizer -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/unittests/Transforms/Vectorize/SandboxVectorizer -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/include -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/include -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googletest/include -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o -MF unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o.d -o unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o -c /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp
In file included from /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:274,
                 from /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/include/llvm/Testing/Support/SupportHelpers.h:17,
                 from /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp:20:
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include/gmock/internal/gmock-internal-utils.h: In instantiation of ‘class testing::internal::StlContainerView<llvm::sandboxir::SeedBundle>’:
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:3786:44:   required from ‘testing::internal::ElementsAreMatcher<MatcherTuple>::operator testing::Matcher<T>() const [with Container = const llvm::sandboxir::SeedBundle&; MatcherTuple = std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*>]’
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:373:12:   required from ‘static testing::Matcher<T> testing::internal::MatcherCastImpl<T, M>::CastImpl(const M&, std::true_type, std::integral_constant<bool, Ignore>) [with bool Ignore = false; T = const llvm::sandboxir::SeedBundle&; M = testing::internal::ElementsAreMatcher<std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*> >; std::true_type = std::integral_constant<bool, true>]’
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:355:20:   required from ‘static testing::Matcher<T> testing::internal::MatcherCastImpl<T, M>::Cast(const M&) [with T = const llvm::sandboxir::SeedBundle&; M = testing::internal::ElementsAreMatcher<std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*> >]’
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:515:47:   required from ‘testing::Matcher<T> testing::MatcherCast(const M&) [with T = const llvm::sandboxir::SeedBundle&; M = testing::internal::ElementsAreMatcher<std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*> >]’
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:522:24:   required from ‘testing::Matcher<T> testing::SafeMatcherCast(const M&) [with T = const llvm::sandboxir::SeedBundle&; M = testing::internal::ElementsAreMatcher<std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*> >]’
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:1591:64:   required from ‘testing::AssertionResult testing::internal::PredicateFormatterFromMatcher<M>::operator()(const char*, const T&) const [with T = llvm::sandboxir::SeedBundle; M = testing::internal::ElementsAreMatcher<std::tuple<llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*, llvm::sandboxir::Instruction*> >]’
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp:316:3:   required from here
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include/gmock/internal/gmock-internal-utils.h:352:15: error: invalid abstract return type ‘llvm::sandboxir::SeedBundle’
  352 |   static type Copy(const RawContainer& container) { return container; }
      |               ^~~~
In file included from /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp:9:
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h:27:7: note:   because the following virtual functions are pure within ‘llvm::sandboxir::SeedBundle’:
   27 | class SeedBundle {
      |       ^~~~~~~~~~
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h:57:16: note: 	‘virtual void llvm::sandboxir::SeedBundle::insert(llvm::sandboxir::Instruction*, llvm::ScalarEvolution&)’
   57 |   virtual void insert(Instruction *I, ScalarEvolution &SE) = 0;
      |                ^~~~~~
7.479 [99/33/108] Linking CXX executable unittests/ExecutionEngine/ExecutionEngineTests
7.574 [99/32/109] Linking CXX executable unittests/Linker/LinkerTests
7.604 [99/31/110] Linking CXX executable unittests/DebugInfo/PDB/DebugInfoPDBTests
7.647 [99/30/111] Linking CXX executable unittests/FuzzMutate/FuzzMutateTests
7.674 [99/29/112] Linking CXX executable unittests/Object/ObjectTests
7.703 [99/28/113] Linking CXX executable bin/sancov
7.705 [99/27/114] Linking CXX executable unittests/ObjectYAML/ObjectYAMLTests
7.783 [99/26/115] Linking CXX executable unittests/ProfileData/ProfileDataTests
7.805 [99/25/116] Linking CXX executable unittests/ObjCopy/ObjCopyTests
7.900 [99/24/117] Linking CXX executable unittests/SandboxIR/SandboxIRTests
7.968 [99/23/118] Linking CXX executable unittests/DebugInfo/LogicalView/DebugInfoLogicalViewTests
7.984 [99/22/119] Linking CXX executable tools/clang/unittests/Analysis/ClangAnalysisTests
7.996 [99/21/120] Linking CXX executable tools/clang/tools/extra/unittests/clang-tidy/ClangTidyTests
8.040 [99/20/121] Linking CXX executable bin/llvm-extract
8.075 [99/19/122] Linking CXX executable bin/llvm-profgen
8.154 [99/18/123] Linking CXX executable tools/clang/unittests/ASTMatchers/ASTMatchersTests

```

</details>

https://github.com/llvm/llvm-project/pull/112979