[llvm] [SYCL][LLVM] Adding property set I/O library for SYCL (PR #110771)

Arvind Sudarsanam via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 21 14:41:17 PDT 2024


asudarsa wrote:

Hi @llvm-beanz 

First of all, thanks so much for your continued reviews here. 
For adding more testing, I looked at unittest/Support/YAMLIOTest.cpp as a reference and I also looked at the use-cases of PropertySetIO in our downstream SYCL compiler.
I have managed to add several test cases covering the use-cases in the SYCL compiler and also several test cases that check if errors are captured as expected.
Kindly take a look when convenient. Please let me know if there are gaps and I will try to handle them.

Thanks again
Sincerely

https://github.com/llvm/llvm-project/pull/110771


More information about the llvm-commits mailing list