[llvm] [LAA] Don't require Stride == 1/-1 for inbounds pointer AddRecs nowrap. (PR #113126)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 21 10:59:54 PDT 2024


fhahn wrote:

> See https://reviews.llvm.org/D149936 for a previous implementation of the same change. We agreed there that this is correct.
> 
> The comment could use an update to stop mentioning "unit stride".
> 

Ah, the comment update was not included in the pushed PR, should be update now!


> It would probably be cleaner to check hasNoUnsignedSignedWrap() instead of isInBounds(), because then this would directly map to the property that LAA is looking for.

Sounds good, there's already https://github.com/llvm/llvm-project/pull/112223

https://github.com/llvm/llvm-project/pull/113126


More information about the llvm-commits mailing list