[llvm] 22e21bc - [llvm][llvm-lit] Correct description of --use-unique-output-file-name

David Spickett via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 21 05:44:20 PDT 2024


Author: David Spickett
Date: 2024-10-21T12:44:12Z
New Revision: 22e21bc1e796406c89e4a24fd81a1623ab2d7d85

URL: https://github.com/llvm/llvm-project/commit/22e21bc1e796406c89e4a24fd81a1623ab2d7d85
DIFF: https://github.com/llvm/llvm-project/commit/22e21bc1e796406c89e4a24fd81a1623ab2d7d85.diff

LOG: [llvm][llvm-lit] Correct description of --use-unique-output-file-name

The initial version of this feature would use the output file name
if it could, but in switching to temp files I forgot to replicate that
behaviour.

What happens now is we always use a tempfile name and the output
path is a template for that. I think the current behaviour
still makes sense so I'm just correcting the documentation.

Added: 
    

Modified: 
    llvm/utils/lit/lit/cl_arguments.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/lit/lit/cl_arguments.py b/llvm/utils/lit/lit/cl_arguments.py
index c08c51b7b7a23e..85744ded597cd7 100644
--- a/llvm/utils/lit/lit/cl_arguments.py
+++ b/llvm/utils/lit/lit/cl_arguments.py
@@ -177,11 +177,10 @@ def parse_args():
     )
     execution_group.add_argument(
         "--use-unique-output-file-name",
-        help="When enabled, lit will not overwrite existing test report files. "
-        "Instead it will write to a new file named the same as the output file "
-        "name but with an extra part before the file extension. For example "
-        "if results.xml already exists, results.<something>.xml will be written "
-        "to. The <something> is not ordered in any way. [Default: Off]",
+        help="When enabled, lit will add a unique element to the output file name, "
+        'before the extension. For example "results.xml" will become '
+        '"results.<something>.xml". The "<something>" is not ordered in any '
+        "way and is chosen so that existing are not overwritten. [Default: Off]",
         action="store_true",
     )
     execution_group.add_argument(


        


More information about the llvm-commits mailing list