[llvm] Fix crash in `CodeGenPrepare.cpp` and `Verifier.cpp` (PR #112772)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 21 05:40:42 PDT 2024


https://github.com/nikic commented:

I don't think this is the right approach to fix this: If llvm.threadlocal.address is used, then we need to hoist that call. Skipping it would defeat the point.

However ... I think this entire pass may just be useless how? Since we switched to using llvm.threadlocal.address, I believe that normal EarlyCSE/GVN and LICM will already perform the optimization this pass is intended to do. Maybe we can just delete this code entirely?

https://github.com/llvm/llvm-project/pull/112772


More information about the llvm-commits mailing list