[llvm] [OPT] Search whole BB for convergence token. (PR #112728)

Sameer Sahasrabuddhe via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 21 02:05:15 PDT 2024


================
@@ -180,6 +180,19 @@ namespace {
     }
   };
 
+  IntrinsicInst *getConevrgenceEntryIfAny(BasicBlock &BB) {
----------------
ssahasra wrote:

The spelling of "convergence" needs to be fixed. Also, "IfAny" is not necessary as a suffix. By convention, most functions simply return a nullptr if none matches.

Also, function should be declared `static`, resulting in internal linkage since the callers are all in this same file.

https://github.com/llvm/llvm-project/pull/112728


More information about the llvm-commits mailing list