[llvm] [VPlan] Use ResumePhi to create reduction resume phis. (PR #110004)
    via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Sun Oct 13 12:46:55 PDT 2024
    
    
  
================
@@ -7493,40 +7501,15 @@ static void createAndCollectMergePhiForReduction(
          "when vectorizing the epilogue loop, we need a resume phi from main "
          "vector loop");
 
-  // TODO: bc.merge.rdx should not be created here, instead it should be
-  // modeled in VPlan.
   BasicBlock *LoopScalarPreHeader = OrigLoop->getLoopPreheader();
-  // Create a phi node that merges control-flow from the backedge-taken check
-  // block and the middle block.
-  auto *BCBlockPhi =
-      PHINode::Create(FinalValue->getType(), 2, "bc.merge.rdx",
-                      LoopScalarPreHeader->getTerminator()->getIterator());
-
   // If we are fixing reductions in the epilogue loop then we should already
----------------
ayalz wrote:
nit: this is no longer a question, we are fixing reductions in the epilogue loop.
https://github.com/llvm/llvm-project/pull/110004
    
    
More information about the llvm-commits
mailing list