[llvm] [BPF] Avoid repeated map lookups (NFC) (PR #112123)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 12 22:22:23 PDT 2024
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/112123
None
>From 645f862948237c7c058daf5d5018e2f0affe5bf0 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sat, 12 Oct 2024 22:17:24 -0700
Subject: [PATCH] [BPF] Avoid repeated map lookups (NFC)
---
.../Target/BPF/BPFAbstractMemberAccess.cpp | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp b/llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp
index 7921518166f97d..39f38259a193b4 100644
--- a/llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp
+++ b/llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp
@@ -221,10 +221,9 @@ bool BPFAbstractMemberAccess::run(Function &F) {
void BPFAbstractMemberAccess::ResetMetadata(struct CallInfo &CInfo) {
if (auto Ty = dyn_cast<DICompositeType>(CInfo.Metadata)) {
- if (AnonRecords.find(Ty) != AnonRecords.end()) {
- if (AnonRecords[Ty] != nullptr)
- CInfo.Metadata = AnonRecords[Ty];
- }
+ auto It = AnonRecords.find(Ty);
+ if (It != AnonRecords.end() && It->second != nullptr)
+ CInfo.Metadata = It->second;
}
}
@@ -234,18 +233,12 @@ void BPFAbstractMemberAccess::CheckCompositeType(DIDerivedType *ParentTy,
ParentTy->getTag() != dwarf::DW_TAG_typedef)
return;
- if (AnonRecords.find(CTy) == AnonRecords.end()) {
- AnonRecords[CTy] = ParentTy;
- return;
- }
-
+ auto [It, Inserted] = AnonRecords.try_emplace(CTy, ParentTy);
// Two or more typedef's may point to the same anon record.
// If this is the case, set the typedef DIType to be nullptr
// to indicate the duplication case.
- DIDerivedType *CurrTy = AnonRecords[CTy];
- if (CurrTy == ParentTy)
- return;
- AnonRecords[CTy] = nullptr;
+ if (!Inserted && It->second != ParentTy)
+ It->second = nullptr;
}
void BPFAbstractMemberAccess::CheckDerivedType(DIDerivedType *ParentTy,
More information about the llvm-commits
mailing list