[llvm] [NFC][AMDGPU] Remove unnecessary member `ForceEmitZeroWaitcnts` (PR #112114)

Shilei Tian via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 12 20:00:56 PDT 2024


https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/112114

We can use `ForceEmitZeroFlag` directly.

>From 0b6952a59f8adb879a8a4a33c9bd5d007c195727 Mon Sep 17 00:00:00 2001
From: Shilei Tian <shilei.tian at amd.com>
Date: Sat, 12 Oct 2024 22:59:55 -0400
Subject: [PATCH] [NFC][AMDGPU] Remove unnecessary member
 `ForceEmitZeroWaitcnts`

We can use `ForceEmitZeroFlag` directly.
---
 llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp b/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
index 15f4114826e401..9866ecbdddb608 100644
--- a/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
+++ b/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
@@ -611,9 +611,6 @@ class SIInsertWaitcnts : public MachineFunctionPass {
 
   MapVector<MachineBasicBlock *, BlockInfo> BlockInfos;
 
-  // ForceEmitZeroWaitcnts: force all waitcnts insts to be s_waitcnt 0
-  // because of amdgpu-waitcnt-forcezero flag
-  bool ForceEmitZeroWaitcnts;
   bool ForceEmitWaitcnt[NUM_INST_CNTS];
 
   // In any given run of this pass, WCG will point to one of these two
@@ -1828,7 +1825,7 @@ bool SIInsertWaitcnts::generateWaitcntInstBefore(MachineInstr &MI,
   // Verify that the wait is actually needed.
   ScoreBrackets.simplifyWaitcnt(Wait);
 
-  if (ForceEmitZeroWaitcnts)
+  if (ForceEmitZeroFlag)
     Wait = WCG->getAllZeroWaitcnt(/*IncludeVSCnt=*/false);
 
   if (ForceEmitWaitcnt[LOAD_CNT])
@@ -2424,7 +2421,6 @@ bool SIInsertWaitcnts::runOnMachineFunction(MachineFunction &MF) {
     WCG = &WCGPreGFX12;
   }
 
-  ForceEmitZeroWaitcnts = ForceEmitZeroFlag;
   for (auto T : inst_counter_types())
     ForceEmitWaitcnt[T] = false;
 



More information about the llvm-commits mailing list