[llvm] [llvm] Fix __builtin_object_size interaction between Negative Offset … (PR #111827)

[via llvm-commits]

serge-sans-paille wrote:

> The PR makes it so that `ObjectSizeOffsetVisitor::visitPHINode` can return different results for the same PHI node when called with a different `ConstantOffset`, but that seems like it would interfere with the caching done in `ObjectSizeOffsetEvaluator::compute_`. I do not have a test case that shows wrong behaviour because of that though.

The cache belongs to the `ObjectSizeOffsetEvaluator` while `ConstantOffset` belongs to `ObjectSizeOffsetVisitor`. I don't see any state shared between the two so I don't see the issue (but it was worth double checking, thanks for having me do that).


https://github.com/llvm/llvm-project/pull/111827