[llvm] [SandboxVectorizer] Add container class to track and manage SeedBundles (PR #112048)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 11 15:03:13 PDT 2024
================
@@ -54,6 +54,10 @@ class SeedBundle {
NumUnusedBits += Utils::getNumBits(I);
}
+ virtual void insert(Instruction *I, ScalarEvolution &SE) {
+ assert("Subclasses must override this function.");
+ }
+
----------------
Sterling-Augustine wrote:
I debated about that, but making the function pure virtual means that the top-level class can't be directly instantiated and therefore can't be tested independently, and most of the functionality is in this class, not the subclasses.
I suppose I could make the test subclass it with a stub implementation, but that seems like extra complexity for not much gain.
https://github.com/llvm/llvm-project/pull/112048
More information about the llvm-commits
mailing list