[llvm] [docs] Update docs on code-review process (PR #111735)
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 11 09:28:35 PDT 2024
================
@@ -150,14 +150,21 @@ almost always associated with a message containing the text "LGTM" (which
stands for Looks Good To Me). Only approval from a single reviewer is required.
When providing an unqualified LGTM (approval to commit), it is the
-responsibility of the reviewer to have reviewed all of the discussion and
+responsibility of the reviewer to have reviewed all of the prior discussion and
feedback from all reviewers ensuring that all feedback has been addressed and
that all other reviewers will almost surely be satisfied with the patch being
approved. If unsure, the reviewer should provide a qualified approval, (e.g.,
"LGTM, but please wait for @someone, @someone_else"). You may also do this if
you are fairly certain that a particular community member will wish to review,
even if that person hasn't done so yet.
+If new comments are posted after the patch has been approved (but not yet
----------------
preames wrote:
You have seemingly managed to complete miss the spirit of my original suggestion, and are misreading the current policy in my view. If the document implies that the author is not responsible for incorporating feedback (because that's only the reviewers responsibility), the document is simply wrong. I don't read it that way, but if you do, stop and fix that wording before working on this smaller item.
https://github.com/llvm/llvm-project/pull/111735
More information about the llvm-commits
mailing list