[llvm] [docs] Update docs on code-review process (PR #111735)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 11 08:05:08 PDT 2024


================
@@ -102,21 +102,9 @@ will not be able to select reviewers in such a way, in which case you can still
 get the attention of potential reviewers by CC'ing them in a comment -- just
 @name them.
 
-A reviewer may request changes or ask questions during the review. If you are
-uncertain on how to provide test cases, documentation, etc., feel free to ask
-for guidance during the review. Please address the feedback and re-post an
-updated version of your patch. This cycle continues until all requests and comments
-have been addressed and a reviewer accepts the patch with a `Looks good to me` or `LGTM`.
-Once that is done the change can be committed. If you do not have commit
-access, please let people know during the review and someone should commit it
-on your behalf.
-
-If you have received no comments on your patch for a week, you can request a
-review by 'ping'ing the GitHub PR with "Ping". The common courtesy 'ping' rate
-is once a week. Please remember that you are asking for valuable time from other
-professional developers.
-
-For more information on LLVM's code-review process, please see :doc:`CodeReview`.
+If you do not have commit access, please let people know during the review and
+someone should commit it on your behalf once it has been accepted. For more
+information on LLVM's code-review process, please see :doc:`CodeReview`.
----------------
nikic wrote:

I feel like this has cut out too much. E.g. I think the "ping" convention should still be mentioned here. This is quite relevant to new contributors, who otherwise don't need to read the full scope of the code review documentation.

https://github.com/llvm/llvm-project/pull/111735


More information about the llvm-commits mailing list