[llvm] [llvm-objdump] Implement decoding auxiliary header for xcoff with llvm-objdump --private-headers (PR #105682)

[James Henderson via llvm-commits]

================
@@ -67,6 +75,179 @@ void XCOFFDumper::printStrHex(StringRef Name, StringRef Str, uint64_t Value) {
          << ")\n";
 }
 
+void XCOFFDumper::printBinary(StringRef Name, ArrayRef<uint8_t> B) {
+  unsigned OrgWidth = getWidth();
+  setWidth(0);
+  outs() << formatName(Name) << " (" << format_bytes(B) << ")\n";
+  setWidth(OrgWidth);
----------------
jh7370 wrote:

> if you strong suggest to remove it, I can remove it.

I was actually suggesting that you should have more testing, with my suggestion being that you could tell if you had sufficient testing by removing a line of code and seeing if a test failed. However, I think your explanation makes sense, thanks, so no need to change things.

https://github.com/llvm/llvm-project/pull/105682