[llvm] [ci] Don't add check-all target when pstl project is enabled (PR #111803)

[David Spickett via llvm-commits]

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/111803

>From c360fd6f4f129f93aab492d433c382fa409ee595 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Thu, 10 Oct 2024 09:36:12 +0100
Subject: [PATCH 1/2] [ci] Don't add check-all target when pstl project is
 enabled

Fixes #110265

Adding check-all causes us to run some tests twice if a project
specific target like check-clang is also added.

check-pstl is an alternative but as far as I can tell, check-all
does not include this so we have not been running the tests in CI
anyway.

When I tried to run check-pstl locally I got a lot of compiler
errors but have not found any instructions on how to setup a
correct build environment. Even if such instructions exist,
it's probably more than we want to do in CI.

According to Louis Dionne, the project is probably not active.
So if it's ever revived it'll be up to the new contributors
to enable testing.
---
 .ci/generate-buildkite-pipeline-premerge | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge
index 53a43070bf1ca3..e61ba909b4c994 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -216,7 +216,7 @@ function check-targets() {
       echo "check-lldb"
     ;;
     pstl)
-      echo "check-all"
+      # Currently we do not run pstl tests in CI.
     ;;
     libclc)
       # Currently there is no testing for libclc.

>From 6af67ff253916eec5d49f5fa618351cb6882f3e3 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Thu, 10 Oct 2024 09:42:52 +0100
Subject: [PATCH 2/2] Add explanatory note

---
 .ci/generate-buildkite-pipeline-premerge | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge
index e61ba909b4c994..7676ff716c4185 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -191,6 +191,9 @@ function keep-modified-projects() {
 }
 
 function check-targets() {
+  # Do not use "check-all" here because if there is "check-all" plus a
+  # project specific target like "check-clang", that project's tests
+  # will be run twice.
   projects=${@}
   for project in ${projects}; do
     case ${project} in