[llvm] [XRay][X86] Handle conditional calls when lowering patchable tail calls (PR #89364)

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 17:36:55 PDT 2024


deanberris wrote:

> Thanks!
> 
> > @deanberris may have an idea why xray handles tail calls specially.
> 
> fwiw, I suspect xray needs to instrument tail calls specially so that the correct caller/callee is relationship is maintained in traces - if a tail call were modeled as a function exit followed by a function entry call, then a caller and its tail callee would appear to be siblings rather than parent/child in the call trace info.

I'm only a few months late to this, but this is precisely why XRay does this. 😄 

https://github.com/llvm/llvm-project/pull/89364


More information about the llvm-commits mailing list