[llvm] Fix scalar overload name constructed by ReplaceWithVeclib.cpp (PR #111095)

Tex Riddell via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 15:12:34 PDT 2024


================
@@ -100,20 +100,39 @@ static void replaceWithTLIFunction(IntrinsicInst *II, VFInfo &Info,
 static bool replaceWithCallToVeclib(const TargetLibraryInfo &TLI,
                                     IntrinsicInst *II) {
   assert(II != nullptr && "Intrinsic cannot be null");
-  // At the moment VFABI assumes the return type is always widened unless it is
----------------
tex3d wrote:

I made the change to rely on using `isVectorIntrinsicWithScalarOpAtArg` as well because it seemed like the right thing to do.  If it ever returned true for the return index `-1`, that would contradict the comment.

However, since I see other paths do not use this for the return and this doesn't return true for index `-1` for any intrinsic, I can change this part back, since it would likely require other code changes if this assumption were to ever change.

https://github.com/llvm/llvm-project/pull/111095


More information about the llvm-commits mailing list