[llvm] [SYCL][LLVM] Adding property set I/O library for SYCL (PR #110771)

Arvind Sudarsanam via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 13:56:16 PDT 2024


asudarsa wrote:

Hi @arsenm, @jhuber6 and @tahonermann 

Thanks so much for the feedback.
I have added three separate commits to address the concerns here.
Commit 1:
Remove changes to Base64 implementation and use existing implementation
Commit 2:
Add SYCL prefix to PropertySet etc.
Commit 3:
Add tests expected to fail and make sure errors are caught

Please take a look when convenient.

Thanks again
Sincerely

https://github.com/llvm/llvm-project/pull/110771


More information about the llvm-commits mailing list