[llvm] [LLVM][TableGen] Check overloaded intrinsic mangling suffix conflicts (PR #110324)

Rahul Joshi via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 08:45:03 PDT 2024


jurahul wrote:

> > We'd need to tag 225 intrinsics. If instead we say that the tag can be on either the overloaded intrinsic or the one that shares the prefix with the overloaded one, its 113 (overloaded) intrinsics that we'd need to tag.
> 
> Adding a bit to change the naming rules is the worst possible outcome. I think we do this, or we do nothing

By "this", you mean this PR as is, right? That is, you don't like the custom bit to opt-out of any checks. If so, I'd say we either commit this PR or atleast add a comment/keep the test to document the conflict rules (since I don't think they are as obvious) for folks to refer to. Let's wait for @nikic to comment as well and decide next steps. @nikic gentle ping when you get a chance, PTAL at the discussion above and advise next steps.

https://github.com/llvm/llvm-project/pull/110324


More information about the llvm-commits mailing list